Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: walletconnect out has helper text #8501

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

twblack88
Copy link
Contributor

Description

Adds an alert div with some text so people know on native wallet to be careful before they jeet out walletconnections.

Issue (if applicable)

Closes #5727 with text we aligned on.

Risk

Low risk, is just a warning alert.

Testing

Spinup local, use native wallet to stare at coonect to Dapp button.
Make sure it looks like this:
Screenshot 2025-01-07 at 2 11 24 PM

Engineering

Worked locally. 😅

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

is above.

@twblack88 twblack88 requested a review from a team as a code owner January 7, 2025 22:17
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-08 at 09 34 36

@0xApotheosis 0xApotheosis merged commit 8264226 into develop Jan 7, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the walletconnect-text branch January 7, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add disclaimer to outbound wallet connect / dapp connections
2 participants