fix: new swapper flow cow buy Tx links #8496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the box - buy Tx hashes were producing a Tx link which was not matching prod i.e /orders/ vs /tx/.
Fixed by ensuring we use the right txId / tradeId property depending on whether or not the current Tx is a buy Tx hash.
Issue (if applicable)
closes #8478
Risk
Low - CoW is the only one leveraging
isOrder
property and having different Tx links programmatic on txId / tradeId.Testing
Engineering
Operations
Screenshots (if applicable)