Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new swapper flow cow buy Tx links #8496

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 7, 2025

Description

Does what it says on the box - buy Tx hashes were producing a Tx link which was not matching prod i.e /orders/ vs /tx/.
Fixed by ensuring we use the right txId / tradeId property depending on whether or not the current Tx is a buy Tx hash.

Issue (if applicable)

closes #8478

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low - CoW is the only one leveraging isOrder property and having different Tx links programmatic on txId / tradeId.

Testing

  • Proceed with a CoW swap e2e
  • Ensure both Tx links are valid

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • develop
Screenshot 2025-01-07 at 23 56 39 https://explorer.cow.fi/orders/0x58e82e87cab4e04826bb621b5c3d14bfa7e0ec29935ce6d96b2ac5b0fef2dd34?tab=orders
  • this diff
Screenshot 2025-01-07 at 23 58 39 https://explorer.cow.fi/tx/0x58e82e87cab4e04826bb621b5c3d14bfa7e0ec29935ce6d96b2ac5b0fef2dd34 image https://explorer.cow.fi/orders/0xfbd2fcba60cff21070362b6258d64a1917f9fbacf6cc8740976f7d1a1d9b52875daf465a9ccf64deb146eeae9e7bd40d6761c986677d9016?tab=overview

@gomesalexandre gomesalexandre marked this pull request as ready for review January 7, 2025 20:04
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 7, 2025 20:04
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xApotheosis 0xApotheosis merged commit b8fd619 into develop Jan 7, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the fix_new_swapper_cow_tx branch January 7, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CoW TX links in new swapper flow
2 participants