Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirm screen shows wrong buyAsset #8495

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Conversation

NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Jan 7, 2025

Description

The swapper confirm screen was using the buyAsset of the first hop instead of the last hop

Issue (if applicable)

closes #8494

Risk

Low (presentational)

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Do a multihop swap (both new trade flow and old trade flow are affected, you can test both but the logic remain very similar)
  • Confirm screen should show the correct buyAsset

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image
image
w

@NeOMakinG NeOMakinG requested a review from a team as a code owner January 7, 2025 18:26
@NeOMakinG NeOMakinG changed the title fix: confirm screen buyAsset fix: confirm screen shows wrong buyAsset Jan 7, 2025
@NeOMakinG NeOMakinG marked this pull request as draft January 7, 2025 19:04
@NeOMakinG NeOMakinG changed the title fix: confirm screen shows wrong buyAsset [wip] fix: confirm screen shows wrong buyAsset Jan 7, 2025
@NeOMakinG NeOMakinG marked this pull request as ready for review January 7, 2025 22:00
@NeOMakinG NeOMakinG changed the title [wip] fix: confirm screen shows wrong buyAsset fix: confirm screen shows wrong buyAsset Jan 7, 2025
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm

Screenshot 2025-01-08 at 09 11 20

@0xApotheosis 0xApotheosis merged commit 281e613 into develop Jan 7, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the multihop-confirm branch January 7, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken/unhandled multi-hop in new trade complete screen
2 participants