chore: handle holistic trade failure status in inner steps #8492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better handles trade failure status in inner steps (new trade flow):
We now show the error icon instead of the "active blue circle".
Issue (if applicable)
Addresses review comment: #8192 (comment)
Risk
Small
None
Testing
Engineering
Ensure new trade flow is active (
REACT_APP_FEATURE_NEW_TRADE_FLOW
).Cause a trade error during the confirmation flow - an easy way to do this is decline a transaction on Metamask etc.
Confirm step shows error icon.
Operations
Screenshots (if applicable)
See description.