Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle holistic trade failure status in inner steps #8492

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

0xApotheosis
Copy link
Member

Description

Better handles trade failure status in inner steps (new trade flow):

Screenshot 2025-01-07 at 18 24 15

We now show the error icon instead of the "active blue circle".

Issue (if applicable)

Addresses review comment: #8192 (comment)

Risk

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

Engineering

Ensure new trade flow is active (REACT_APP_FEATURE_NEW_TRADE_FLOW).

Cause a trade error during the confirmation flow - an easy way to do this is decline a transaction on Metamask etc.

Confirm step shows error icon.

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

See description.

@0xApotheosis 0xApotheosis requested a review from a team as a code owner January 7, 2025 07:27
@0xApotheosis 0xApotheosis mentioned this pull request Jan 7, 2025
1 task
@gomesalexandre gomesalexandre self-requested a review January 7, 2025 09:44
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:

  • Approval/Tx signing rejected in wallet triggers hollisti swap step error ✅
image
  • Final quote error triggers holistic error state ✅
image

@gomesalexandre gomesalexandre merged commit 37c764e into develop Jan 7, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the handle-holistic-trade-failuer branch January 7, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants