Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new swapper tweaks #8489

Merged
merged 4 commits into from
Jan 7, 2025
Merged

chore: new swapper tweaks #8489

merged 4 commits into from
Jan 7, 2025

Conversation

0xApotheosis
Copy link
Member

Description

Actions some review feedback from #8192

  • Makes the inner steps contractable on the trade completion summary (the expandy icon is there, so it should probably behave how the user expects when clicked)
  • Changes "last hop" to "second hop" vernacular to better represent the referenced data
  • Uses the receive address from the quote, rather than the hook (as we should always have a receive address at the time of trade confirm, and that's the address that will be used in the trade)

Issue (if applicable)

Addresses feedback from #8192

Risk

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

Engineering

With the REACT_APP_FEATURE_NEW_TRADE_FLOW flag enabled, check the changes noted in the description.

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

N/A

@0xApotheosis 0xApotheosis requested a review from a team as a code owner January 7, 2025 05:19
@gomesalexandre gomesalexandre self-requested a review January 7, 2025 09:09
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, confirmed this does what is says on the box:

  • Collapsible bits are indeed collapsible/expandy

https://jam.dev/c/ab1b0924-f4cd-42ec-9fba-2d95897d4180

  • Custom/Receive addy is still happy and funds are received on the correct address

https://jam.dev/c/69302e95-0e8e-473b-9eb1-76928a2866ed

Note @0xApotheosis unrelated to this diff but noting we've lost the receive address info i.e note how it is present on the "pre-preview" stage, but as soon as we're at execution screen, this data is not available anymore. We should probably re-surface it there somehow, as it should probably be visible to users at all time? 🤔

image image image

@0xApotheosis 0xApotheosis changed the title chore: new swapper treaks chore: new swapper tweaks Jan 7, 2025
@gomesalexandre gomesalexandre enabled auto-merge (squash) January 7, 2025 09:53
@gomesalexandre gomesalexandre merged commit f380ad1 into develop Jan 7, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the swapper-tweaks-20250107 branch January 7, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants