[wip] feat: rfox for lpoors #8455
Draft
+1,169
−633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP PR for CLI tooling update and IPFS metadata updates - shapeshift/rFOX#95 |
kaladinlight
reviewed
Jan 7, 2025
| @@ -2646,13 +2646,15 @@ | |||
| "confirmAndBridge": "Confirm & Bridge", | |||
| "myStakedBalance": "My Staked Balance", | |||
| "myStakedBalanceHelper": "The amount of FOX you have staked", | |||
| "pendingRewardsBalance": "Current Estimated Rewards Balance", | |||
| "pendingRewardsBalance": "Pending Rewards Balance", | |||
There was a problem hiding this comment.
Was this discussed with @shapeshift/product? We had updated to "Current Estimated" because that is all it is, you may get more or less by epoch close, so to call it "Pending" is a misnomer since the value isn't really truly pending until epoch close.
There was a problem hiding this comment.
I've taken it from the Figma but it might be outdated, checking with @shapeshift/product which copy is the right one
NeOMakinG
commented
Jan 7, 2025
| select, | ||
| }: UseGetUnstakingRequestCountQueryProps<SelectData>) => { | ||
| // wagmi doesn't expose queryFn, so we reconstruct the queryKey and queryFn ourselves to leverage skipToken type safety | ||
| const queryKey: GetUnstakingRequestCountQueryKey = useMemo( | ||
| () => [ | ||
| 'readContract', | ||
| { | ||
| address: RFOX_PROXY_CONTRACT, | ||
| address: contractAddress, |
There was a problem hiding this comment.
Auto review: in some hooks we pass the contract address, some other has the assetId, choose between one and stick with it
kaladinlight
force-pushed
the
rfox-lpoors
branch
from
82214f9 to
ab46a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stakeAssetIdorselectedAssetIddepending if the selected asset it is the fox on ETHIssue (if applicable)
closes #7911
Risk
Let's say high, funds could be at risk somehow, sending to the wrong address
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)