feat: toggle limit orders on in production #8452
Merged
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toggles limit orders on in production. See here for preliminary ops testing:
https://discord.com/channels/554694662431178782/1324596242394644571/1324596246949924944
Issue (if applicable)
closes NA
Risk
None - this is a placeholder PR.
Testing
Signed off by ops, ops to test in release. See here for preliminary ops testing:
https://discord.com/channels/554694662431178782/1324596242394644571/1324596246949924944
NOTE - this is a completely new feature with minimal eng testing. Although this looks visually similar to spot trades, almost none of the actual logic is shared between this and trades, so treat everything like it's never been tested before and assume everything is broken and full of bugs.
Also note there's likely more surface area to test not listed here.
Input
Allowance approval
Unable to approve allowance for USDT
warning when USDT allowance >0 but insufficient for current orderConfirmation
Orders (IMPORTANT!⚠️ )
Open Orders list
Order History List
Engineering
Operations
Screenshots (if applicable)