Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide thorswap free fee banner after 2024 #8435

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

NeOMakinG
Copy link
Collaborator

Description

After the new year, hide the THOR Swap free fee banner, as fees will be applied again (didn't add it as early return of the component itself for easier understanding purpose

Issue (if applicable)

closes #8422

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • I personally spoofed it with a chrome extension (Time Travel), but as your own discretion!

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image

@NeOMakinG NeOMakinG requested a review from a team as a code owner December 20, 2024 16:36
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the monkey patch below

diff --git a/src/lib/fees/model.ts b/src/lib/fees/model.ts
index f7dd288a82..c3219ccadb 100644
--- a/src/lib/fees/model.ts
+++ b/src/lib/fees/model.ts
@@ -9 +9 @@ export const THORSWAP_UNIT_THRESHOLD = 1
-export const THORSWAP_MAXIMUM_YEAR_TRESHOLD = 2025
+export const THORSWAP_MAXIMUM_YEAR_TRESHOLD = 2024

Confirmed this does what it says on the box!

image

@NeOMakinG NeOMakinG merged commit bab6906 into develop Dec 20, 2024
3 checks passed
@NeOMakinG NeOMakinG deleted the thor-banner branch December 20, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

THOR Free fees banner should be removed automatically after the new year
2 participants