-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: minimise asset data size #8423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lated asset index" This reverts commit bd04c84.
woodenfurniture
force-pushed
the
asset-list-sorting
branch
from
December 20, 2024 04:42
1a79883
to
edcbeec
Compare
woodenfurniture
force-pushed
the
asset-list-sorting
branch
from
December 20, 2024 05:07
19e4d13
to
47f6b08
Compare
woodenfurniture
force-pushed
the
asset-list-sorting
branch
from
December 20, 2024 05:08
47f6b08
to
3d8dd3f
Compare
gomesalexandre
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolute beast of a PR ser. See runtime testing below. A few non/blocking comments to tackle at your convenience but overall: hell yeah.
Tested locally:
yarn && yarn build:packages && yarn && yarn generate:encode-asset-data
is happy and codegen looks good ✅
- App smoke test looks good after full cache nuke ✅
https://jam.dev/c/71520bff-f1e7-4eab-80f7-845fa042ef24
- Chain selection looks good ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces bundle size by reducing the size occupied by our generated asset data, to effectively mitigate our bundle size being right on the cloudflare limit (See #7768)
generatedAssetData.json
by a factor of 3x.relatedAssetIndex.json
by a factor of 51x.TODO:
relatedAssetKey
issue upstream (fix: dont use missing/stale related asset data when generating the related asset index #8424)relatedAssetIndex
using the encoded assetIdssortedAssetIds
in reduxrelatedAssetIndex.json
andgeneratedAsssetData.json
before mergegenerate:encode-asset-data
script and associated filesUpdating branch
Issue (if applicable)
closes #8188
closes #8047
Risk
High risk. Makes extensive changes to asset data generation and consumption.
None.
Testing
Should be no change compared to production.
Engineering
Operations
Screenshots (if applicable)