feat: switch assets remove wallet support limitations #8393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows up on #8381 i.e "make assets switch button less pain p.2".
The rationale here is users do not know the inner workings of the app. They shouldn't be blocked from switching assets because we wouldn't handle the current buy asset as a sell asset gracefully (we actually do!).
The reason why this was here previously is most likely because of pre-quotes without wallet connected, where we wouldn't be able to yield quotes (now rates) without a wallet connected for both chains, but we're now able to so let's ditch this in an effort to make things feel less broken and more ergonomic 🎉
Issue (if applicable)
Risk
Low to none, ensure assets unsupported by wallet are handled gracefully
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/f2d3bfb3-245d-4db0-9335-b4881c28e6a7