Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch assets remove wallet support limitations #8393

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 17, 2024

Description

Follows up on #8381 i.e "make assets switch button less pain p.2".

The rationale here is users do not know the inner workings of the app. They shouldn't be blocked from switching assets because we wouldn't handle the current buy asset as a sell asset gracefully (we actually do!).

The reason why this was here previously is most likely because of pre-quotes without wallet connected, where we wouldn't be able to yield quotes (now rates) without a wallet connected for both chains, but we're now able to so let's ditch this in an effort to make things feel less broken and more ergonomic 🎉

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low to none, ensure assets unsupported by wallet are handled gracefully

Testing

  • Select a buy asset unsupported by wallet
  • Ensure you can switch assets, and said unsupported asset is properly caught as such as errored state in the confirm button

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/f2d3bfb3-245d-4db0-9335-b4881c28e6a7

@gomesalexandre gomesalexandre marked this pull request as ready for review December 17, 2024 18:13
@gomesalexandre gomesalexandre requested a review from a team as a code owner December 17, 2024 18:13
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gomes on a PR streak!

https://jam.dev/c/4e6d096e-0b7e-47ce-9f3b-3b0a4755de9f

We can get this in

@NeOMakinG NeOMakinG enabled auto-merge (squash) December 18, 2024 14:55
@NeOMakinG NeOMakinG merged commit 5b983f2 into develop Dec 18, 2024
3 checks passed
@NeOMakinG NeOMakinG deleted the feat_rm_walletsupport_limitations_switchAssets branch December 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants