-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update trade complete screen #8240
Conversation
@reallybeard do you want to provide the animation? and any oils if you wish! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/MultiHopTrade/components/TradeSuccess/TradeSuccess.tsx
Outdated
Show resolved
Hide resolved
src/components/MultiHopTrade/components/MultiHopTradeConfirm/MultiHopTradeConfirm.tsx
Show resolved
Hide resolved
src/components/MultiHopTrade/components/MultiHopTradeConfirm/MultiHopTradeConfirm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM!
https://jam.dev/c/5a361a0f-cd29-46c1-868f-15d1e6e56940
A few non-blocking comments.
86541e9
to
3b45b41
Compare
Description
We want to add the assets and amounts to the trade complete screen, including an animation on the check icon
I deleted unused stuff and implemented the needed props to display the assets and amounts
Issue (if applicable)
closes #8027
Risk
Low
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)