Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update trade complete screen #8240

Merged
merged 8 commits into from
Dec 3, 2024
Merged

fix: update trade complete screen #8240

merged 8 commits into from
Dec 3, 2024

Conversation

NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Dec 2, 2024

Description

We want to add the assets and amounts to the trade complete screen, including an animation on the check icon

I deleted unused stuff and implemented the needed props to display the assets and amounts

Issue (if applicable)

closes #8027

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Pass a few trades, including multi hops if possible, so you can see that buyAsset and sellAsset is the right one as well as amounts

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image

@NeOMakinG
Copy link
Collaborator Author

@reallybeard do you want to provide the animation? and any oils if you wish!

@NeOMakinG NeOMakinG marked this pull request as ready for review December 2, 2024 21:03
@NeOMakinG NeOMakinG requested a review from a team as a code owner December 2, 2024 21:03
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says! One preferably blocking comment.

Screenshot 2024-12-03 at 11 47 33

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!
https://jam.dev/c/5a361a0f-cd29-46c1-868f-15d1e6e56940

A few non-blocking comments.

@NeOMakinG NeOMakinG enabled auto-merge (squash) December 3, 2024 17:38
@NeOMakinG NeOMakinG merged commit 35c005c into develop Dec 3, 2024
3 checks passed
@NeOMakinG NeOMakinG deleted the trade-complete branch December 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update trade complete screen
5 participants