fix: trades from native assets & utxos #6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
Feb 20, 2024
0xApotheosis
added a commit
that referenced
this pull request
Feb 21, 2024
* fix: trades from native assets & utxos (#6260) fix: native allowance * fix: use correct chain id for matching buy account * fix: allow quote sell amounts to be lower than user input sell amount (#6265) * fix: allow quote sell amounts to be lower than user input sell amount * fix: fix logic, add a teeny tiny thrshold so cowswap works * fix: consolidate matching buy account id selection logic (#6268) * chore: fix merge --------- Co-authored-by: kaladinlight <[email protected]> Co-authored-by: woody <[email protected]>
gomesalexandre
pushed a commit
that referenced
this pull request
Feb 22, 2024
* fix: trades from native assets & utxos (#6260) fix: native allowance * fix: use correct chain id for matching buy account * fix: allow quote sell amounts to be lower than user input sell amount (#6265) * fix: allow quote sell amounts to be lower than user input sell amount * fix: fix logic, add a teeny tiny thrshold so cowswap works * fix: consolidate matching buy account id selection logic (#6268) * chore: fix merge --------- Co-authored-by: kaladinlight <[email protected]> Co-authored-by: woody <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in release which prevents trading from native assets or UTXOs.
Regression from #6217
Problem summary:
useIsApprovalNeededwas returningundefinedifselectAllowanceCryptoBaseUnitevaluated toundefined(which happens in the case of native fee assets or UTXOsisApprovalNeededto beundefinedfor these assets, causing theisLoadingcondition ofisApprovalNeeded === undefinedto be metPull Request Type
Issue (if applicable)
N/A - current release blocker.
See #6257 (comment).
Risk
Medium. A small change, but does affect the approval checks of transactions.
Any transaction that requires an approval check (trades and LP deposits).
Testing
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
Infinite spinner state that this fixes: