fix: regression of smart contract sell address checks on validateTradeQuote

[gomesalexandre]

Description

Spotted in https://github.com/shapeshift/web/pull/5971/files#diff-b6f4d6672824399e71740531e3b09efe3ad3fabeb3ad6c4ce0763969f9d39ab7R210

see:

web/src/state/apis/swappers/helpers/validateTradeQuote.ts

Line 210 in 3b9b81e

const _isSmartContractAddress = await isSmartContractAddress(quote.receiveAddress)

vs. previous implementation:

web/src/components/MultiHopTrade/hooks/quoteValidation/useActiveQuoteStatus.tsx

Lines 47 to 53 in 6581379

	const userAddress = useMemo(() => {
	if (!sellAssetAccountId) return ''
	return fromAccountId(sellAssetAccountId).account
	}, [sellAssetAccountId])
	const { data: _isSmartContractAddress } = useIsSmartContractAddress(userAddress)

This means that we effectively do not validate on the sell side anymore, but on the receive side instead, which is an extremely high-risk regression.
This however is mitigated by the fact we have a similar and correct check in-place at input step:

web/src/components/MultiHopTrade/components/TradeInput/TradeInput.tsx

Lines 209 to 216 in 255d8b7

	const userAddress = useMemo(() => {
	if (!sellAssetAccountId) return ''
	return fromAccountId(sellAssetAccountId).account
	}, [sellAssetAccountId])
	const { data: _isSmartContractAddress, isLoading: isAddressByteCodeLoading } =
	useIsSmartContractAddress(userAddress)

This PR reverts to the previous behavior.

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes N/A, spotted while working on another PR.

Risk

High Risk PRs Require 2 approvals

• Low to none as this reverts to the previous behavior. high risk tag becaue this fixes a high-risk regression.

Testing

• With an actual smart-contract wallet (e.g Gnosis Safe through WC) ensure you are blocked from trading on THOR
• With Frame-injected smart-contract wallet address, ensure you are blocked from trading on THOR

Engineering

• ☝🏽

Operations

• ☝🏽

Screenshots (if applicable)

Tested with frame-injected user smart-contract wallet address

• Develop

Note isSmartContractAddress returns false, since we're passing the receive DOGE address instead of the smart-contract wallet on the sell side

• This diff

[gomesalexandre]

Current dependencies on/for this PR:

• release
  • PR fix: regression of smart contract sell address checks on validateTradeQuote #6081 👈
    • PR feat: holistic custom recipient address part 2 #6072

This stack of pull requests is managed by Graphite.