fix: zrx base URLs #5955
Merged
fix: zrx base URLs #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
0xApotheosis
reviewed
Jan 8, 2024
Comment on lines
-20
to
-30
| return 'https:/0x.shapeshift.com/ethereum' | ||
| return 'https://0x.shapeshift.com/ethereum/' | ||
| case KnownChainIds.AvalancheMainnet: | ||
| return 'https:/0x.shapeshift.com/avalanche' | ||
| return 'https://0x.shapeshift.com/avalanche/' | ||
| case KnownChainIds.OptimismMainnet: | ||
| return 'https:/0x.shapeshift.com/optimism' | ||
| return 'https://0x.shapeshift.com/optimism/' | ||
| case KnownChainIds.BnbSmartChainMainnet: | ||
| return 'https:/0x.shapeshift.com/bnbsmartchain' | ||
| return 'https://0x.shapeshift.com/bnbsmartchain/' | ||
| case KnownChainIds.PolygonMainnet: | ||
| return 'https:/0x.shapeshift.com/polygon' | ||
| return 'https://0x.shapeshift.com/polygon/' | ||
| case KnownChainIds.ArbitrumMainnet: | ||
| return 'https:/0x.shapeshift.com/arbitrum' |
There was a problem hiding this comment.
Oh man, I stared at this code for so long but didn't notice the single forward slash - good find @gomesalexandre!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward slashes rugged.
Pull Request Type
Issue (if applicable)
Risk
Testing
Engineering
Operations
Screenshots (if applicable)
ZRX is happy on Localhost
ZRX is happy on deploys