Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swapper dot-first notation input #5871

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 15, 2023

Description

Does what it says on the box

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5818

Risk

Swapper input may be borked under certain scenarios?

Testing

  • Dot notation input is happy as a first input
  • Dot notation input is happy when inputting an integer/float not in the dot notation (i.e 0.1 or 1, but not .1), selecting all text, and inputting a dot notation number instead
  • Input doesn't wrongly change to the wrong notation when the input loses focus (i.e click outside of swapper)

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

dot.mov

@gomesalexandre gomesalexandre requested a review from a team as a code owner December 15, 2023 06:10
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@woodenfurniture woodenfurniture enabled auto-merge (squash) December 17, 2023 21:46
@woodenfurniture woodenfurniture force-pushed the fix_swapper_dot_notation_input branch from e651a95 to 2a833bd Compare December 17, 2023 21:47
@woodenfurniture woodenfurniture merged commit 423d789 into develop Dec 17, 2023
1 check passed
@woodenfurniture woodenfurniture deleted the fix_swapper_dot_notation_input branch December 17, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swapper doesn't allow input of "." in certain scenarios
2 participants