feat: search entire UniswapV3 fee range for longtail swaps #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xApotheosis
commented
Dec 15, 2023
Comment on lines
+64
to
+67
| TSAggregatorUniswapV3_100 = '0xbd68cbe6c247e2c3a0e36b8f0e24964914f26ee8', | ||
| TSAggregatorUniswapV3_500 = '0xe4ddca21881bac219af7f217703db0475d2a9f02', | ||
| TSAggregatorUniswapV3_3000 = '0x11733abf0cdb43298f7e949c930188451a9a9ef2', | ||
| TSAggregatorUniswapV3_10000 = '0xb33874810e5395eb49d8bd7e912631db115d5a03', |
There was a problem hiding this comment.
THORChain will blackhole funds if any of these are wrong - they must be whitelisted on https://gitlab.com/thorchain/thornode/-/blob/develop/x/thorchain/aggregators/dex_mainnet_current.go
0xApotheosis
force-pushed
the
add-v3-fee-ranges
branch
2 times, most recently
from
07146fb to
bb312d0
Compare
0xApotheosis
force-pushed
the
add-v3-fee-ranges
branch
from
f6f1f0a to
be74145
Compare
src/lib/swapper/swappers/ThorchainSwapper/utils/longTailHelpers.ts
Outdated
Show resolved
Hide resolved
woodenfurniture
approved these changes
Dec 19, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds UniswapV3 pool optimization to long-tail swaps, enabling more assets and better rates.
This PR adds the ability to search all fee ranges for a given asset pair's available pools, get a quote for each, and transact against the contract resulting in the best rate. In particular, we'll get better rates for assets with tight liquidity pools.
Also adds support for additional assets that did not have pools for the
3000fee range of UniswapV3.An example to see this working: compare the rate between this branch and prod for LINK to DOGE.
Pull Request Type
Issue (if applicable)
Closes #5878
Risk
High risk to long-tail swaps - we'll want to test these again, as messing up the contracts here (e.g. using a non-whitelisted contract) could lead to funds landing in a black hole.
Testing
Perform longtail swaps on a range of assets (the sell asset is important, not so much the buy asset - so just use the cheapest).
Engineering
Sanity check the contract selection logic - using the wrong aggregator contract will cause lost funds.
Operations
☝️
Screenshots (if applicable)
N/A