Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback fees for doge #5853

Merged
merged 5 commits into from
Dec 13, 2023
Merged

fix: fallback fees for doge #5853

merged 5 commits into from
Dec 13, 2023

Conversation

kaladinlight
Copy link
Contributor

Description

Replaces: #5851 (please read here for more details)

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5822

Risk

  • Low

Testing

  • Ensure you are able to successfully broadcast doge transactions

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

@kaladinlight kaladinlight requested a review from a team as a code owner December 13, 2023 17:48
gomesalexandre
gomesalexandre approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:

  • Negative fast fee
Screenshot 2023-12-13 at 22 14 46 Screenshot 2023-12-13 at 22 17 51
  • Monkey patched negative average fees
image image
  • Monkey patched negative slow fees
image image

@gomesalexandre gomesalexandre mentioned this pull request Dec 13, 2023
Closed
3 tasks
@kaladinlight kaladinlight changed the base branch from develop to release December 13, 2023 18:56
@kaladinlight kaladinlight merged commit ffbd40d into release Dec 13, 2023
3 checks passed
@kaladinlight kaladinlight deleted the fix-doge-fees branch December 13, 2023 18:57
@gomesalexandre gomesalexandre mentioned this pull request Dec 13, 2023
Merged
@gomesalexandre gomesalexandre mentioned this pull request Dec 21, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to send Doge
3 participants
@kaladinlight @gomesalexandre @woodenfurniture