Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove foxy rebase history #5777

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 5, 2023

Description

This PR:

  • removes rebase functionality from investor-foxy and web consumption
  • removes the notion of rebase from web useBalanceChartData and txHistorySlice
  • removes now unused Infura env var

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5736

Risk

  • EVM accounts (and consequently, net worth) balances may be borked, test accordingly

Testing

  • Ensure FOXy price is still happy
  • Ensure FOXy DeFi opportunity, user data (balances) and functionality (deposit/withdraw/claim) is still happy
  • Ensure EVM accounts' balances looks sane against prod
  • Ensure net worth looks sane against prod

Engineering

  • ☝🏽
  • grep for rebase and ensure all runtime occurences are gone

Operations

  • ☝🏽

Screenshots (if applicable)

FOXy balance

  • Prod
Screenshot 2023-12-05 at 11 35 19
  • This diff
Screenshot 2023-12-05 at 11 35 27

Net worth

  • Prod
Screenshot 2023-12-05 at 11 34 54

FOXy DeFi

  • This diff
image
  • Prod
image
  • This diff
Screenshot 2023-12-05 at 11 35 00

Perf

  • Prod
Screenshot 2023-12-05 at 11 46 30 Screenshot 2023-12-05 at 11 46 23

Notes:

  1. in prod, Infura and our JSON-RPC node requests are decoupled. That's because develop isn't whitelisted for Infura, so we use our node as a bandaid currently, which makes FOxy unreliable in localhost currently
  2. JSON-RPC requests are batched, and prod being faster, the batching may be more efficient, so the number of requests in prod vs. here for the same account isn't really indicative of anything
  • This diff
Screenshot 2023-12-05 at 11 44 46

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review December 5, 2023 10:56
@gomesalexandre gomesalexandre requested a review from a team as a code owner December 5, 2023 10:56
@woodenfurniture woodenfurniture force-pushed the feat_rm_foxy_rebase_history branch from 3e56acb to 709048e Compare December 5, 2023 20:02
@woodenfurniture woodenfurniture self-assigned this Dec 5, 2023
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass, stamp

@gomesalexandre gomesalexandre merged commit 1df5260 into develop Dec 6, 2023
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_rm_foxy_rebase_history branch December 6, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rebase support for FOXY
2 participants