Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rambo remove web idle #5757

Merged
merged 4 commits into from
Dec 4, 2023
Merged

feat: rambo remove web idle #5757

merged 4 commits into from
Dec 4, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 4, 2023 •
edited
Loading

Description

Removes Idle from web, but does not remove it from market-service and asset-service, so we still have Idle assets market and asset data.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5729

Risk

Testing

Engineering

Operations

Screenshots (if applicable)

  • Idle DeFi opportunities are now removed, and only available as a read-only Zapper opportunity, effectively not breaking the display of Idle positions for clients with an active Idle position 🎉
image
  • Idle market data is still happy
image

@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review December 4, 2023 11:25
@gomesalexandre gomesalexandre requested a review from a team as a code owner December 4, 2023 11:25
@twblack88
Copy link
Contributor

twblack88 commented Dec 4, 2023 •
edited
Loading

You're going to hate me but we got a 250K deposit on Dec1.

@woodenfurniture
Copy link
Member

as discussed we're going ahead with this as users can manage their idle externally

@woodenfurniture woodenfurniture enabled auto-merge (squash) December 4, 2023 22:58
@woodenfurniture woodenfurniture merged commit ed079e3 into develop Dec 4, 2023
3 checks passed
@woodenfurniture woodenfurniture deleted the feat_rambo_remove_idle branch December 4, 2023 23:03
@0xApotheosis 0xApotheosis mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Idle finance from application
4 participants
@gomesalexandre @twblack88 @woodenfurniture @kaladinlight