-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor multi-hop state tracking to avoid duplicate states and associated logic #5745
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
6b70f3d
to
04f57ac
Compare
src/components/MultiHopTrade/components/MultiHopTradeConfirm/components/ApprovalStep.tsx
Show resolved
Hide resolved
src/components/MultiHopTrade/components/MultiHopTradeConfirm/components/Footer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, looks excellent and more declarative - will stamp after a functional regression pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
04f57ac
to
36b94d9
Compare
Description
Refactors the state management of multi-hop trade execution to remove duplicate and redundant states and the resulting logic required to keep them aligned. As a result, there is less responsibility of the view layer to manage and know about the working of trades at a higher level and allows them to dispatch narrow-context actions to redux.
Pull Request Type
Issue (if applicable)
closes #5740
Risk
All of the work here is focused on multi-hop trades (behind feature flag), but there is a risk these changes could affect the functionality of the production trade and approval state management.
Testing
Test trades and erc20 approvals are still working as expected.
Engineering
Operations
Screenshots (if applicable)
Multi-hop UI still working correctly with mock hooks