feat: thorchain use max_streaming_quantity quantity in memos #5734
+54
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #5733 (comment) for reference - this tackles part of our problem by ensuring our streaming quantity conforms to the one returned by the quote as
max_streaming_quantity
.This does not yet tackle the issue of 0 limit memos returned by THOR we then ignore and set our own limit instead.
Pull Request Type
Issue (if applicable)
Risk
0
indicateslet the network decide the best streaming quantity
. Meaning that would be explicit instead of implicit here, but the actual limit used by THOR would be the sameTesting
Engineering
max_streaming_interval
Operations
Screenshots (if applicable)
Tested with two pairs/amounts as the quantity may differ depending on the pairs/amounts
10,000 USDT -> DAI
0
quantity53
streaming quantity0.08 BTC -> DOGE
0
quantity2
quantity