feat: improve thorchain Txs failure detection #5708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relies on Midgard for failure and success detection in conjunction to our current
/tx/status
checks.This allows us to more reliably detect success Txs when enforcing outbound checks by ensuring we have a succesful
out
Tx, as well as properly detect refunds, both succesful and failed.Pull Request Type
Issue (if applicable)
closes #5702
Risk
Testing
Engineering
web/src/features/defi/providers/thorchain-savers/components/ThorchainSaversManager/Withdraw/components/Withdraw.tsx
Lines 638 to 646 in 680c550
Operations
Screenshots (if applicable)
swap_status.pending === false