fix: borked 0x pairs #5678
Closed
fix: borked 0x pairs #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
gomesalexandre
commented
Nov 22, 2023
| @@ -60,7 +60,7 @@ export async function getZrxTradeQuote( | |||
| } | |||
|
|
|||
| const maybeZrxPriceResponse = await fetchFromZrx({ | |||
| priceOrQuote: 'price', | |||
| priceOrQuote: 'quote', | |||
There was a problem hiding this comment.
Note, we do not effectively use this anymore (we're always passing 'quote' now) but we may
|
Closing as broadcasting this would revert anyway 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes (some) borked 0x pairs. For some reason, using the price endpoint with no validation to get a quote, then using the quote endpoint with validation is causing the latter (i.e the pre-broadcast quote) to respond with 400.
Fixed by consistently using the
/quoteendpoint, and consistently skipping validation - as our flow makes it so that by the time of<TradeConfirm />, we are already in a state where allowance is granted.Pull Request Type
Issue (if applicable)
closes #5598
Risk
Testing
Engineering
Operations
Screenshots (if applicable)