Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active step indicator for hops without allowance approval #5671

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Nov 21, 2023

Description

Fixes the blue border missing on the step indicator in the multi-hop UI for a swap/bridge step when there is no ERC20 token approval required.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5670

Risk

Low risk, behind feature flag.

Testing

Not required.

Engineering

Operations

Screenshots (if applicable)

image

@woodenfurniture woodenfurniture requested a review from a team as a code owner November 21, 2023 22:13
@woodenfurniture
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@woodenfurniture woodenfurniture force-pushed the multihop-active-step-fix branch from 2a30875 to b2187d5 Compare November 22, 2023 22:06
@woodenfurniture woodenfurniture merged commit 9f90944 into develop Nov 22, 2023
1 check passed
@woodenfurniture woodenfurniture deleted the multihop-active-step-fix branch November 22, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active step border not rendering for swap/bridge steps without approval
2 participants