-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thorchain savers withdraw sweep #5640
Merged
gomesalexandre
merged 14 commits into
develop
from
feat_thorchain_savers_withdraw_sweep
Nov 20, 2023
Merged
feat: thorchain savers withdraw sweep #5640
gomesalexandre
merged 14 commits into
develop
from
feat_thorchain_savers_withdraw_sweep
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
gomesalexandre
commented
Nov 20, 2023
gomesalexandre
commented
Nov 20, 2023
src/lib/utils/thorchain/hooks/useGetThorchainSaversWithdrawQuoteQuery.tsx
Show resolved
Hide resolved
gomesalexandre
commented
Nov 20, 2023
...roviders/thorchain-savers/components/ThorchainSaversManager/Withdraw/components/Withdraw.tsx
Outdated
Show resolved
Hide resolved
gomesalexandre
commented
Nov 20, 2023
...roviders/thorchain-savers/components/ThorchainSaversManager/Withdraw/components/Withdraw.tsx
Show resolved
Hide resolved
gomesalexandre
commented
Nov 20, 2023
...ders/thorchain-savers/components/ThorchainSaversManager/Overview/ThorchainSaversOverview.tsx
Outdated
Show resolved
Hide resolved
src/lib/utils/thorchain/hooks/useGetThorchainSaversWithdrawQuoteQuery.tsx
Show resolved
Hide resolved
woodenfurniture
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
some non-blocking comments, but lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The follow-up of #5614, for withdraws.
Additionally:
staleTime
, to avoid spamming THORgetHasEnoughXYZ
into reusable methodsexpected_amount_out
andquote.fees.outbound
to ensure we get an outbound fees quotePull Request Type
Issue (if applicable)
closes #5619
Risk
Withdraws are borked because of UTXO reconciliation and high fees currently, so this should only bring improvements.
Testing
Engineering
Operations
Screenshots (if applicable)
Sweep needed
Sweep not needed i.e all funds in zeroth address
Minimum not met
Minimum met, but too low fees (UX to be confirmed by @reallybeard)
EVM withdraw
ATOM withdraw