Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented trade success ui for multi-hop trades #5639

Merged
merged 2 commits into from
Nov 20, 2023
Merged

feat: implemented trade success ui for multi-hop trades #5639

merged 2 commits into from
Nov 20, 2023

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Nov 20, 2023 •
edited
Loading

Description

Implements the trade success ui for multi hop trades.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

NA

Risk

Low risk as no production-facing code is changed.

Testing

Not required.

Engineering

Operations

Screenshots (if applicable)

Successful trade with details expanded - note the success ui shows the user BALANCE, not the amount that was received during the trade (cc @reallybeard)
image

Successful trade with details hidden
image

@woodenfurniture woodenfurniture requested a review from a team as a code owner November 20, 2023 02:06
@woodenfurniture
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

0xApotheosis
0xApotheosis approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this guy as-is considering it's behind a flag.

gomesalexandre
gomesalexandre approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually happy with this guy minus missing translations, can be tackled all at once across multi-hop domain as a follow-up if you feel like it 🤌

@woodenfurniture woodenfurniture force-pushed the multi-hop-trade-progression-12 branch from 897b7ee to ff55cd1 Compare November 20, 2023 20:41
@woodenfurniture woodenfurniture enabled auto-merge (squash) November 20, 2023 20:42
@woodenfurniture woodenfurniture merged commit 773db11 into develop Nov 20, 2023
6 checks passed
@woodenfurniture woodenfurniture deleted the multi-hop-trade-progression-12 branch November 20, 2023 20:46
@woodenfurniture woodenfurniture mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodenfurniture @gomesalexandre @0xApotheosis