fix: approvals failing for non-eth EVM chains #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
woodenfurniture
force-pushed
the
fix-approvals
branch
from
075a871 to
abb52f9
Compare
.../providers/thorchain-savers/components/ThorchainSaversManager/Deposit/components/Approve.tsx
Outdated
Show resolved
Hide resolved
gomesalexandre
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Tested against develop:
Non-Ethereum EVM chains trade approvals
- This diff
- Develop
THORChain savers deposit
- Develop
- This diff
Didn't test UNI-V2 because of insufficient funds for gas, though Ethereum Mainnet is the only supported chain there so LGTM also, will defer to ops for UNI-V2 testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken ERC20 allowance approvals for non-eth EVM chains.
Pull Request Type
Issue (if applicable)
closes #5571
closes #5573
closes #5574
Risk
Risk of approvals still broken for EVM chains
Testing
Check approvals work for all EVM chains
Engineering
Note that this includes a fix to use the viem public client per chain, and I've hardcoded all other uses of the function to use ETH mainnet. Please double check this is correct for all cases where i've hardcoded it.
Operations
Screenshots (if applicable)
FOX/ETH LP appearing also
