Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default route #5534

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: change default route #5534

merged 3 commits into from
Oct 25, 2023

Conversation

reallybeard
Copy link
Contributor

Description

This changes the default route to trade, removes the trade widget on dashboard and recent txs on trade.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5533

Risk

Small risk

Testing

Engineering

Operations

When connecting a wallet, you should be taken to the /trade page and not dashboard.

When on the trade page you'll see no recent transactions, and when going to the dashboard you should not see the trade widget.

Screenshots (if applicable)

@reallybeard reallybeard requested a review from a team as a code owner October 25, 2023 16:17
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

  • Confirmed default route is now trade
  • Confirm returnUrl route is also trade

@gomesalexandre gomesalexandre merged commit 8e9f456 into develop Oct 25, 2023
3 checks passed
@gomesalexandre gomesalexandre deleted the WEB-5533 branch October 25, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default route to trade
2 participants