Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clear opportunities migration #5515

Merged
merged 3 commits into from
Oct 23, 2023
Merged

feat: clear opportunities migration #5515

merged 3 commits into from
Oct 23, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 23, 2023 •
edited
Loading

Description

Ensures we don't end up with borked FOXy state - see #5484

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

contributes to #5484

Risk

None

Testing

@shapeshift/operations to test #5484

I managed to repro the claim state on your account, but it went away after a few seconds of state reconciliation, this is what I can see now. I believe if the user was fast enough to click it, that could've happened
  • Ensure there is no pending withdraw mistakenly shown for FOXy when it is not actually possible to withdraw (i.e the claim Tx would go through but nothing would be withdrawn)

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review October 23, 2023 11:59
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 23, 2023 11:59
@gomesalexandre gomesalexandre enabled auto-merge (squash) October 23, 2023 18:38
@gomesalexandre gomesalexandre merged commit 2107116 into develop Oct 23, 2023
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_clear_opportunities branch October 23, 2023 18:45
@0xApotheosis 0xApotheosis mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @kaladinlight