Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replace snapshot.js sdk with an axios request #5483

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

woodenfurniture
Copy link
Member

Description

Enhances app boot time for low-compute mobile devices by removing unused packages. In this instance, removes @snapshot-labs/snapshot.js and replaces it with an axios request.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5482

Risk

risk of fox voting power fetch broken

Testing

check fox voting power is fetch when wallet is connected:
image

Engineering

Operations

Screenshots (if applicable)

@woodenfurniture woodenfurniture requested a review from a team as a code owner October 18, 2023 00:28
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still gets voting power correctly 👌

@0xApotheosis 0xApotheosis enabled auto-merge (squash) October 18, 2023 03:56
@0xApotheosis 0xApotheosis merged commit bd68920 into develop Oct 18, 2023
3 checks passed
@0xApotheosis 0xApotheosis deleted the perf-remove-snapshotjs branch October 18, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove snapshot.js from project
2 participants