Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable walletconnect in mobile app #2753

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

cjthompson
Copy link
Contributor

Description

Disables wallet connect in the mobile app due to outstanding issues.

See shapeshift/mobile-app#47 and shapeshift/mobile-app#54

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

shapeshift/mobile-app#47
shapeshift/mobile-app#54

Risk

None. It doesn't disable it for web or mobile browser, just the mobile app

Testing

Launch in web and mobile browser and click Connect Wallet. You will still see Wallet Connect.

Launch in the mobile app and it won't be there

Engineering

To test you'll need

  1. Mobile app running in simulator/emulator
  2. Use mobile app develop modal to switch to Localhost (trigger the modal in the Android emulator by opening the sensors settings and moving the device left and right to simulate a shake)
  3. Run web locally

Operations

There's no way to test by ops until it's merged into develop and gets deployed to develop.shapeshift.com

Screenshots (if applicable)

Mobile

image

Web

image

@cjthompson cjthompson requested a review from a team as a code owner September 14, 2022 19:39
@0xdef1cafe 0xdef1cafe enabled auto-merge (squash) September 14, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants