Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow output amount to be swapped into input amount when a user attempts to reverse the input / output #8376

Closed
0xean opened this issue Dec 16, 2024 · 1 comment
Assignees

Comments

@0xean
Copy link
Contributor

0xean commented Dec 16, 2024

https://jam.dev/c/f5ff458c-0ce9-4f20-94d2-54ca19368830

Repro steps:

  1. create a quote
  2. click the down arrow to swap assets
  3. See that it doesn't swap the assets amounts as user might expect.

Potential solution:

Effectively we want to take the fiat value of the current sell asset, and input that fiat amount worth of buy asset on switch.

@0xean 0xean added the bug Something isn't working label Dec 16, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Dec 16, 2024
@gomesalexandre
Copy link
Contributor

@0xean what's the expected behaviour here, for the value in sell asset to become the same one in buy asset, with the assets reversed i.e something like this?
image

If so, unfortunately we can't do that, as buy asset value is not an input, i.e we don't (as most of the swappers don't either) support the notion of getting a quote denominated in buy asset value.

@0xean 0xean removed the bug Something isn't working label Dec 16, 2024
@0xean 0xean changed the title Down arrow to swap assets is broken when getting quotes Allow output amount to be swapped into input amount when a user attempts to reverse the input / output Dec 16, 2024
@gomesalexandre gomesalexandre self-assigned this Dec 17, 2024
@gomesalexandre gomesalexandre moved this from Up next / groomed to In progress in ShapeShift Dashboard Dec 17, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants