Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapper doesn't allow input of "." in certain scenarios #5818

Closed
0xean opened this issue Dec 8, 2023 · 1 comment · Fixed by #5871
Closed

Swapper doesn't allow input of "." in certain scenarios #5818

0xean opened this issue Dec 8, 2023 · 1 comment · Fixed by #5871
Assignees
Labels
bug Something isn't working V3 Swapper

Comments

@0xean
Copy link
Contributor

0xean commented Dec 8, 2023

Overview

If you attempt to enter a number that leads with a decimal in the swapper ".15" for example when there is already a value in the modal, it instead enters a "0" when you have pressed "." instead.

References and additional details

Steps to repro:

  1. Enter a value into the swapper input (0.15 for example)
  2. obtain a quote for that amount in
  3. click the input amount highlighting the input amount and attempt to enter ".16", instead you will end up with 016 and then 16

Acceptance Criteria

Swapper inputs accept a decimal correctly.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@0xean 0xean added bug Something isn't working V3 Swapper labels Dec 8, 2023
@0xean
Copy link
Contributor Author

0xean commented Dec 8, 2023

Screen.Recording.2023-12-08.at.3.00.34.PM.mov

In this screen recording, I attempted to enter ".16"

@twblack88 twblack88 moved this from To schedule to Up next in ShapeShift Dashboard Dec 11, 2023
@gomesalexandre gomesalexandre moved this from Up next to In review in ShapeShift Dashboard Dec 15, 2023
@gomesalexandre gomesalexandre self-assigned this Dec 15, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V3 Swapper
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants