Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade testing #17

Merged
merged 3 commits into from
Apr 11, 2024
Merged

chore: upgrade testing #17

merged 3 commits into from
Apr 11, 2024

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Apr 11, 2024 •
edited
Loading

Closes #7

@gomesalexandre gomesalexandre self-requested a review April 11, 2024 07:41
gomesalexandre
gomesalexandre approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Upgrades test look sane to me
  • FoxStaking.sol rename to FoxStakingV1.sol, with MockFoxStakingV2 being present only in tests

Note, while not strictly related to this PR, coverage is now sad 😢

Will tackle as follow-up.

image

@gomesalexandre gomesalexandre merged commit 14c2976 into main Apr 11, 2024
1 check passed
@0xean 0xean deleted the upgradeable-contract-3 branch May 29, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add upgradeable and unit tests to upgrade
2 participants
@woodenfurniture @gomesalexandre