Skip to content

Commit

Permalink
Don't update Bundler in generator specs (#539)
Browse files Browse the repository at this point in the history
* TEST: Don't update Bundler in generator specs
* Try use latest rubygems
  • Loading branch information
tomdracz authored Jan 7, 2025
1 parent 0829d5a commit af76122
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/dummy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.1.2'
rubygems: latest
- name: Install dependencies
run: |
bundle install
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/generator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,6 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
rubygems: latest
bundler-cache: true
- run: bundle exec rake run_spec:generator
2 changes: 2 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
rubygems: latest
bundler-cache: true

- name: Ruby rubocop
Expand Down Expand Up @@ -69,6 +70,7 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
rubygems: latest
bundler-cache: true

- name: Ruby specs
Expand Down
2 changes: 0 additions & 2 deletions spec/generator_specs/generator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@
# Issue resolved in Capybara v3.40.0, but Ruby 2.7 support dropped; last compatible version is v3.39.2.
# Ref: https://github.com/shakacode/shakapacker/issues/498
sh_in_dir({}, BASE_RAILS_APP_PATH, %(
gem update bundler
echo 'gem "shakapacker", :path => "#{GEM_ROOT}"' >> Gemfile
echo 'gem "rack", "< 3.0.0"' >> Gemfile
bundle install
))
else
sh_in_dir({}, BASE_RAILS_APP_PATH, %(
gem update bundler
bundle add shakapacker --path "#{GEM_ROOT}"
))
end
Expand Down

0 comments on commit af76122

Please sign in to comment.