fix: Fix Chromedriver download for version 115+ #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome has a new distribution system since version 115.
alekzz
approved these changes
Aug 17, 2023
| @@ -77,12 +95,32 @@ class ChromeWebDriverInstaller extends WebDriverInstallerBase { | |||
| * @return {!Promise} | |||
| */ | |||
| async install(driverVersion, outputDirectory) { | |||
| const majorVersion = parseInt(driverVersion.split('.')[0], 10); | |||
There was a problem hiding this comment.
nit; parseInt(driverVersion.split('.')[0], 10) can be extracted to a function.
There was a problem hiding this comment.
parseInt is already a function, right?
| * @return {!Promise} | ||
| */ | ||
| async installNew_(majorVersion, driverVersion, outputDirectory) { | ||
| let platform; |
There was a problem hiding this comment.
Line 155-169 can be extracted to a getPlatform function
There was a problem hiding this comment.
No, the platform strings used in the old and new styles differ slightly.
There was a problem hiding this comment.
Ex: Before 115, it was mac_arm64 for Arm and mac64 Intel. From 115 on, it's mac-arm64 and mac-x64.
Ex: Before 115, it was win32 for Windows. From 115 on, it's win64.
joeyparrish
changed the title
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome has a new distribution system since version 115.