Skip to content

Commit

Permalink
ci: Fix player version check on release (#5728)
Browse files Browse the repository at this point in the history
The player version format changed to split the JS string into parts in
PR #5724, but the version check for release workflows did not get a
corresponding update, causing the npm release workflow to fail. This
fixes that.
  • Loading branch information
joeyparrish committed Oct 4, 2023
1 parent d1d67d5 commit 52c412e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/checkversion.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def player_version():
"""Gets the version of the library from player.js."""
path = os.path.join(shakaBuildHelpers.get_source_base(), 'lib', 'player.js')
with shakaBuildHelpers.open_file(path, 'r') as f:
match = re.search(r'shaka\.Player\.version = \'(.*)\'', f.read())
match = re.search(r'shaka\.Player\.version = \'(.*?)\'', f.read())
return match.group(1) if match else ''


Expand Down Expand Up @@ -70,7 +70,7 @@ def main(_):
if 'v' + npm != git:
logging.error('NPM version does not match git version.')
ret = 1
if player != git + '-uncompiled':
if player != git:
logging.error('Player version does not match git version.')
ret = 1
if 'v' + changelog != git:
Expand Down

0 comments on commit 52c412e

Please sign in to comment.