Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render without rendering #2152

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Render without rendering #2152

wants to merge 5 commits into from
+333 −118

Conversation

viniciuslrangel
Copy link
Collaborator

  • Redraw last frame to keep rendering the ImGui
  • Draw the game as a imgui window

image

@niko1point0
Copy link

niko1point0 commented Jan 15, 2025 •
edited
Loading

Will this work if a frame has "never" been rendered? Some games have MsgDialog on the first frame, before any graphics are ever submitted with GnmSubmitCommandBuffers, such as Knack update v1.10

[Edit]: Knack update v1.10 with ps4 pro mode enabled in the config

@viniciuslrangel
Copy link
Collaborator Author

Will this work if a frame has "never" been rendered? Some games have MsgDialog on the first frame, before any graphics are ever submitted with GnmSubmitCommandBuffers, such as Knack update v1.10

[Edit]: Knack update v1.10 with ps4 pro mode enabled in the config

In theory, yes. Are you able to test it?

@kalaposfos13
Copy link
Contributor

imgui_new
With this PR, every game has its brightness completely broken.
(Linux Mint 22, 3060 Laptop GPU)

@niko1point0
Copy link

niko1point0 commented Jan 15, 2025 •
edited
Loading

Works on Knack v1.10 in Pro mode! You have my approval!

image

@niko1point0
Copy link

niko1point0 commented Jan 16, 2025 •
edited
Loading

Hold on @viniciuslrangel can you test if game patches work? This PR might break game patches. For some reason none of my Knack patches work in this PR build, but they work with the regular master shadps4, even if I drag my PR exe into the same directory as my master shadps4 exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psucien psucien Awaiting requested review from psucien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viniciuslrangel @niko1point0 @kalaposfos13