Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -depfile work for binary slang-modules #6126

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

juliusikkala
Copy link
Contributor

Previously, -depfile <filename> would create an empty file when .slang-module is requested and there is no -target. This PR makes -depfile also output dependencies for slang-modules. This can be used in build systems (e.g. CMake, that's my use case) to make sure that all files importing a module get rebuilt when that module is edited.

@juliusikkala juliusikkala requested a review from a team as a code owner January 17, 2025 23:23
Copy link
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Jan 17, 2025
@csyonghe csyonghe merged commit d09b6bc into shader-slang:master Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants