Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow __subscript<T> syntax. #6124

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Allow __subscript<T> syntax. #6124

merged 3 commits into from
Jan 17, 2025
+51 −17

Conversation

csyonghe
Copy link
Collaborator

@csyonghe csyonghe commented Jan 17, 2025 •
edited
Loading

Closes #6125.

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Jan 17, 2025
@csyonghe csyonghe requested a review from a team as a code owner January 17, 2025 21:10
saipraveenb25
saipraveenb25 previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@saipraveenb25 saipraveenb25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This will simplify a lot of the SlangPy code

@csyonghe csyonghe merged commit d1a13a7 into shader-slang:master Jan 17, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saipraveenb25 saipraveenb25 saipraveenb25 left review comments

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support generic syntax on __subscript.
2 participants
@csyonghe @saipraveenb25