Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline global constants that contains opaque handles for legalization. #6098

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Inline global constants that contains opaque handles for legalization. #6098

merged 5 commits into from
Jan 16, 2025

Conversation

csyonghe
Copy link
Collaborator

Closes #4874.

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Jan 15, 2025
@csyonghe csyonghe requested a review from a team as a code owner January 15, 2025 21:25
@csyonghe csyonghe requested a review from kaizhangNV January 15, 2025 23:30
kaizhangNV
kaizhangNV approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@kaizhangNV kaizhangNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csyonghe csyonghe merged commit 387f2be into shader-slang:master Jan 16, 2025
16 checks passed
@kaizhangNV kaizhangNV mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizhangNV kaizhangNV kaizhangNV approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource variables used in a global initializer function do not hoist correctly
2 participants
@csyonghe @kaizhangNV