Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of SP#015 DescriptorHandle<T>. #6028

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Initial implementation of SP#015 DescriptorHandle<T>. #6028

wants to merge 22 commits into from
+1,294 −406

Conversation

csyonghe
Copy link
Collaborator

@csyonghe csyonghe commented Jan 8, 2025 •
edited
Loading

Closes #6038.

Closes #6010.

@csyonghe csyonghe added the pr: non-breaking PRs without breaking changes label Jan 8, 2025
@csyonghe
Copy link
Collaborator Author

csyonghe commented Jan 8, 2025

/format

@slangbot
Copy link
Contributor

slangbot commented Jan 8, 2025

🌈 Formatted, please merge the changes from this PR

@slangbot slangbot mentioned this pull request Jan 8, 2025
Merged
@csyonghe csyonghe changed the title Initial implementation of ResourcePtr<T>. Initial implementation of SP#016 DescriptorHandle<T>. Jan 8, 2025
@csyonghe csyonghe changed the title Initial implementation of SP#016 DescriptorHandle<T>. Initial implementation of SP#015 DescriptorHandle<T>. Jan 9, 2025
@natevm
Copy link
Contributor

natevm commented Jan 9, 2025

Just looked over the proposal. LGTM 👍🏻

jkwak-work
jkwak-work previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I left some questions, but I probably have some misunderstandings.

docs/proposals/015-descriptor-handle.md Outdated Show resolved Hide resolved
docs/proposals/015-descriptor-handle.md Outdated Show resolved Hide resolved
source/slang/hlsl.meta.slang Outdated Show resolved Hide resolved
jkwak-work
jkwak-work previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

docs/user-guide/03-convenience-features.md Outdated Show resolved Hide resolved
jkwak-work
jkwak-work approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwak-work jkwak-work jkwak-work approved these changes

@tangent-vector tangent-vector Awaiting requested review from tangent-vector tangent-vector is a code owner

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1 expipiplus1 is a code owner

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
4 participants
@csyonghe @slangbot @natevm @jkwak-work