Use disassemble API from SPIRV-Tools #6001
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses C API version of SPIRV disassemble function rather than calling spirv-dis.exe. This allows us to use a correct version of SPIRV disassble function that Slangc.exe is using.
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
…mble_API_from_SPIRV_Tools Format code for PR shader-slang#6001
|
Converting to draft while working on the failing test |
csyonghe
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses C API version of SPIRV disassemble function rather than calling spirv-dis.exe.
This allows us to use a correct version of SPIRV disassble function that Slangc.exe is using.
The implementation is mostly copied from
external/spirv-tools/tools/dis/dis.cpp, which is a source file for building spirv-dis.exe.