Allow explicit test root #5980
Merged
Allow explicit test root #5980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
csyonghe
previously approved these changes
Jan 1, 2025
|
This will make slang-test easier to use during development. Thank you for contributing the patch! |
|
The change seems to break existing tests. |
|
...and specifically on Windows for some reason. Will take a look at what's going on, thanks for the heads up. |
auto-merge was automatically disabled
January 2, 2025 01:07
Head branch was pushed to by a user without write access
|
Ah, tests are breaking because of an unintentional change in the path separator. I was using |
csyonghe
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to address #5979.
From what I can tell, this should be a non-breaking change. The existing tests still run correctly, and I've verified on my computer that I can use an arbitrary test directory with the
-test-diroption.While attempting to implement this, I did also notice an off-by-one issue with the binary name on Linux. While
_calcExectuablePathproperly null-terminates the program path, it overwrites the final non-null character of the name. This ends up breaking functions likePath::getCanonicallater on, becauseslang-tesdoes not exist. If that change should be in a separate PR, please let me know.