Fix WGSL varying input attributes #5937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairywreath
changed the title
csyonghe
approved these changes
Dec 26, 2024
| @@ -1348,6 +1356,195 @@ struct LegalizeWGSLEntryPointContext | |||
| } | |||
| } | |||
|
|
|||
| void hoistEntryPointParameterFromStruct(EntryPointInfo entryPoint) | |||
There was a problem hiding this comment.
Are these exactly the same as metal? if so we can move it to a shared file and call the function from both backends.
There was a problem hiding this comment.
I initially copied them but I am getting crashes and test regressions, I will need more time to fix this. Another option is to just add new code to add semantic attributes to the parameters, but reusing code from Metal and refactoring(including refactoring of the existing) wgsl legalization code that is duplicated from Metal is still worth it IMO.
|
I will create a separate PR for this, changes from this PR are not valid anymore after the refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5933.
This is a quick fix that copies code from Metal legalization (function packStageInParameters) to WGSL legalization, where individual varying inputs are placed into a global struct. Currently, WGSL does not properly add location qualifiers to the individual varying inputs.
This is not a permanent solution and will need to be refactored later. Issue #4657 tracks the refactoring effort of applying metal's legalization to the common entry point legalization context This change is also related to PR #5498, where code duplication already exists, further highlighting the need for refactoring and share the metal specific legalization logic to other backends.
[Draft because explicit vk locations are broken]