fix metal by including it in more compile passes

shader-slang · Aug 21, 2024 · dc2b47a · dc2b47a
1 parent dbc7ae2
commit dc2b47a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/source/slang/slang-emit.cpp b/source/slang/slang-emit.cpp
@@ -1221,7 +1221,7 @@ Result linkAndOptimizeIR(
     // concrete value.
     // These sort of GlobalVar's should be removed in-favor of directly
     // using the known value since this may be an indirect use of a resource
-    // variable (which is illegal for most targets).
+    // variable (which is illegal for almost targets).
     simplifyGlobalVars(irModule);
 
     switch( target )

diff --git a/source/slang/slang-ir-specialize-resources.cpp b/source/slang/slang-ir-specialize-resources.cpp
@@ -1202,7 +1202,9 @@ bool specializeResourceOutputs(
     HashSet<IRFunc*>&          unspecializableFuncs)
 {
     auto targetRequest = codeGenContext->getTargetReq();
-    if(isD3DTarget(targetRequest) || isKhronosTarget(targetRequest))
+    // D3D & SPIRV/GLSL cannot easily use resources as parameters
+    // Metal cannot assign globals to resource-outputting functions (in global scope)
+    if(isD3DTarget(targetRequest) || isKhronosTarget(targetRequest) || isMetalTarget(targetRequest))
     {}
     else
     {