Add related name to Comments.author #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernd-wechner
force-pushed
the
fix-comment-clash
branch
2 times, most recently
from
365b443 to
dff907e
Compare
shacker
reviewed
Sep 28, 2021
| @@ -0,0 +1,20 @@ | |||
| # Generated by Django 2.2.24 on 2021-09-22 22:05 | |||
There was a problem hiding this comment.
Please give the migration a useful filename, like 0012_set_comments_related_name
There was a problem hiding this comment.
Can do. Have to work out how first 😉
shacker
reviewed
Sep 28, 2021
| @@ -133,7 +133,8 @@ class Comment(models.Model): | |||
| """ | |||
|
|
|||
| author = models.ForeignKey( | |||
| settings.AUTH_USER_MODEL, on_delete=models.CASCADE, blank=True, null=True | |||
| settings.AUTH_USER_MODEL, on_delete=models.CASCADE, blank=True, null=True, | |||
| related_name="todo_comments" | |||
There was a problem hiding this comment.
I would think this change would break todo code in at least one place, no? Will test soon. But the system still works for you?
There was a problem hiding this comment.
All existing tests passed. The code is running live and in use. And there are no references to comment_set, the default related_name anywhere in the code base. Looks safe to me.
There was a problem hiding this comment.
Excellent, thank you for looking.
shacker
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Issue 126:
#126