Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentations for Installation #1733

Closed
wants to merge 0 commits into from

Conversation

zhaochenyang20
Copy link
Collaborator

Motivation

I added documents for the installation right now. Other files like docs/en/quick_start.md could be ignored and I will wrap it into index.rst later.

Modifications

#1487

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

docs/en/install.md Outdated Show resolved Hide resolved
docs/en/install.md Outdated Show resolved Hide resolved
docs/en/install.md Outdated Show resolved Hide resolved
docs/en/install.md Outdated Show resolved Hide resolved
docs/en/install.md Outdated Show resolved Hide resolved
# Server Quick Start

This guide will help you quickly set up and run the SGLang server, and send test requests for both generative and embedding models.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current outline

- Step 1
   - Generative model (90% user)
   - Embedding model  (10% user)
- Step 2
   - Generative model (90% user)
   - Embedding model  (10% user)

Correct outline

- Generative model (90% user)
  - Step 1
  - Step 2
- Embedding model (10% user)
  - Step 1
  - Step 2

@merrymercy
Copy link
Contributor

Principal:

  • Common case first, move edge cases to the end
  • Make it concise
  • Make the commands runnable and continuous

@zhaochenyang20
Copy link
Collaborator Author

@merrymercy Hey, plz check if this version of install.md is what you'd prefer.

@@ -0,0 +1,40 @@
# Backend Overview
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file necessary? i think the paper already provides a good overview

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document serves as a learning guide, and I believe it is necessary. As you can gain insights from the Stoicheia, there remains a need to acquire new Geometry material. Anyway, I will set this aside for now and ensure it is placed appropriately later.

docs/en/index.rst Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
# How to Support a New Model
# Add New Models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the change of this file, and only keep install.md

@@ -1,14 +1,20 @@
SGLang Documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the change of this file, and only keep install.md

pip install --upgrade pip
pip install "sglang[all]"

# Install FlashInfer CUDA kernels
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this

lmsysorg/sglang:latest \
python3 -m sglang.launch_server --model-path meta-llama/Llama-3.1-8B-Instruct --host 0.0.0.0 --port 30000
python3 -m sglang.launch_server --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --host 0.0.0.0 --port 30000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this line

@zhaochenyang20
Copy link
Collaborator Author

thanks for help @merrymercy @ByronHsu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants