Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BAI/VCF POS paragraphs #195

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add BAI/VCF POS paragraphs #195

wants to merge 1 commit into from

Conversation

percyfal
Copy link
Contributor

@percyfal percyfal commented Jan 8, 2025

  • exemplify old indexing formats that are ill suited for large genomes
  • motivate why the VCFs were partitioned
  • mention VCF POS limitation and how this could affect other genomes with large chromosomes

@percyfal
Add BAI/VCF POS paragraphs
195028f 
- exemplify old indexing formats that are ill suited for large genomes
- motivate why the VCFs were partitioned
- mention VCF POS limitation and how this could affect other genomes
  with large chromosomes
@percyfal
Copy link
Contributor Author

percyfal commented Jan 8, 2025

Addresses #180.

jeromekelleher
jeromekelleher reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Needs a few references but we can do that in another pass

@percyfal
Copy link
Contributor Author

percyfal commented Jan 9, 2025 •
edited
Loading

Ah, ok, I labelled it as a draft PR because I was thinking to add refs and expand later on, adding text now so as not to forget. Although I did convert the coordinates as we discussed previously, I have not added this code anywhere. I also wonder if we should just mention that it can be done and not bother with a practical example?

@jeromekelleher
Copy link
Contributor

I also wonder if we should just mention that it can be done and not bother with a practical example?

Sounds good to me - it's pretty a trivial operation, and it would be hard to pull out from all the "setup" code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromekelleher jeromekelleher jeromekelleher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@percyfal @jeromekelleher