Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibreSSL 4.0.0 #2315

Merged
merged 2 commits into from
Oct 15, 2024
Merged

LibreSSL 4.0.0 #2315

merged 2 commits into from
Oct 15, 2024

Conversation

botovq
Copy link
Contributor

@botovq botovq commented Oct 15, 2024

LibreSSL 4.0.0 was released. It's stable.

Alternate PR to #2314

LibreSSL 3.7 is out of support, so replace it with just released 4.0.
Bump 3.9 branch to 3.9.2 and 3.8 branch to 3.8.4.
@@ -380,6 +380,8 @@ See rust-openssl documentation for more information:
(3, 8, _) => ('3', '8', 'x'),
(3, 9, 0) => ('3', '9', '0'),
(3, 9, _) => ('3', '9', 'x'),
(4, 0, 0) => ('4', '0', '0'),
(4, 0, _) => ('4', '0', 'x'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are y'all committing that there will be no ABI breaking changes and that 4.0.1 will be stable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do. As the release announcement says:

We have released LibreSSL 4.0.0, which will be arriving in the LibreSSL directory of your local OpenBSD mirror soon. This is the first stable release for the 4.0.x branch, also available with OpenBSD 7.6

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, in that case I think we don't need the first line, and we only need the 40x line (and to update the existing checks in the code)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe I misunderstood the intent of the "x" lines, I think this is fine as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also unsure, but I think it makes sense to stick with what we used to do previously. Usually we release one or two test releases, but this didn't happen this time for various reasons.

@alex alex merged commit ee3b024 into sfackler:master Oct 15, 2024
67 checks passed
@botovq botovq deleted the libressl-4.0.0 branch October 15, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants